fix: Remove tiled writer if submitted task doesn't exist#1484
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1484 +/- ##
==========================================
+ Coverage 95.23% 95.25% +0.01%
==========================================
Files 43 43
Lines 3151 3159 +8
==========================================
+ Hits 3001 3009 +8
Misses 150 150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tpoliaw
force-pushed
the
duplicate-tiled-writers
branch
from
0b2da0d to
d525c8d
Compare
Contributor
|
Nit: could use a more descriptive name than |
dan-fernandes
approved these changes
Apr 16, 2026
Whenever a task is submitted, a TiledWriter is added to the run engine and is only removed when the task is complete. If the task never starts due to not being found, the writer would never be removed and subsequent tasks would have duplicate writers causing write errors to tiled. Catching the KeyError and removing the subscribers immediately is a workaround that works but should be removed when the internal pending tasks queue is removed.
system tests don't count for coverage
tpoliaw
force-pushed
the
duplicate-tiled-writers
branch
from
6502871 to
a43b27c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever a task is submitted, a TiledWriter is added to the run engine
and is only removed when the task is complete. If the task never starts
due to not being found, the writer would never be removed and subsequent
tasks would have duplicate writers causing write errors to tiled.
Catching the KeyError and removing the subscribers immediately is a
workaround that works but should be removed when the internal pending
tasks queue is removed.
Fixes #1480